add support for user_agent configuration #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlj
reviewed
Feb 12, 2023
| @@ -126,7 +127,7 @@ static void _cast_channel_save_downloaded_enclosure(gpointer key, | |||
| g_free(escaped_key); | |||
| } | |||
|
|
|||
| static int _cast_channel_save_channel(FILE *f, gpointer user_data, int debug) | |||
| static int _cast_channel_save_channel(FILE *f, gpointer user_data, int debug, channel *cc) | |||
There was a problem hiding this comment.
Please rename the new parameter to c for consistency.
(Ideally, we'd avoid this new parameter, cf. comment on _rss_open_url_cb()).
| @@ -143,6 +144,9 @@ struct channel_configuration *channel_configuration_new( | |||
|
|
|||
| if (!c->regex_filter && defaults->regex_filter) | |||
| c->regex_filter = g_strdup(defaults->regex_filter); | |||
|
|
|||
| if (!c->user_agent && defaults->user_agent) | |||
| c->user_agent = g_strdup(defaults->user_agent); | |||
There was a problem hiding this comment.
Please also free the duplicated string in channel_configuration_free().
| @@ -252,20 +253,20 @@ rss_file *rss_open_file(const char *filename) | |||
| return f; | |||
| } | |||
|
|
|||
| static int _rss_open_url_cb(FILE *f, gpointer user_data, int debug) | |||
| static int _rss_open_url_cb(FILE *f, gpointer user_data, int debug, channel *c) | |||
| { | |||
| gchar *url = (gchar *)user_data; | |||
There was a problem hiding this comment.
I think it would be better if you passed the channel to the function via user_data, i.e. use a struct with the URL and the channel and pass a pointer to that struct.
That said, the callbacks already make this code hard to read, and it is in general need of a rewrite so perhaps it's better to address this separately after merging this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31
demo:
client machine:
server apache logs: